Re: [Qemu-trivial] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library

[Kevin Wolf]

Am 10.03.2015 um 15:01 hat Michael Tokarev geschrieben:
> 10.03.2015 16:58, Stefan Hajnoczi пишет:
> > On Tue, Mar 10, 2015 at 10:09 AM, Kevin Wolf <address@hidden> wrote:
> >> Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben:
> >>> On Tue, 03/10 09:50, Kevin Wolf wrote:
> >>>> Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben:
> >>>> Also, should we consider making some more rarely used image formats
> >>>> modules even if they don't pull in external dependencies?
> >>>
> >>> Sounds reasonable to me. Is the intention to reduce binary size?
> >>
> >> Yes, that and also that it allows compiling out some drivers without
> >> having to mess with the Makefiles. You just don't install all of them.
> >>
> >> Related to that, Peter also mentioned that you (the user, not developer
> >> or packager) could simply disable a single driver, for example as a
> >> temporary hotfix in the case of security problems in a block driver.
> >> That would actually be an argument for making _all_ drivers modules.
> > 
> > I am for making all block drivers built as modules.
> 
> That might be useful if module loading will be modified a bit,
> like by loadin modules on demand only.  Something like this,
> search a "foo" block driver in the registered list, found ->
> use it, if not, try to open block-foo.so (maybe after looking
> in the "available" internal list before that) and look up in
> the registered list again.
> 
> That will make it more useful.

The problem with that would be that format probing wouldn't work any
more for drivers that aren't loaded yet.

Kevin