qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] fsdev/virtfs-proxy-helper: Fix possible overflow


From: Shannon Zhao
Subject: [Qemu-trivial] [PATCH] fsdev/virtfs-proxy-helper: Fix possible overflow
Date: Fri, 13 Mar 2015 19:09:57 +0800

It's detected by coverity. As max of sockaddr_un.sun_path is
sizeof(helper.sun_path), should check the length of source
and use strncpy instead of strcpy.

Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
---
 fsdev/virtfs-proxy-helper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index bf2e5f3..f12d7a0 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -738,6 +738,7 @@ static int proxy_socket(const char *path, uid_t uid, gid_t 
gid)
         return -1;
     }
 
+    g_assert(strlen(path) < sizeof(proxy.sun_path));
     sock = socket(AF_UNIX, SOCK_STREAM, 0);
     if (sock < 0) {
         do_perror("socket");
@@ -748,7 +749,7 @@ static int proxy_socket(const char *path, uid_t uid, gid_t 
gid)
     umask(7);
 
     proxy.sun_family = AF_UNIX;
-    strcpy(proxy.sun_path, path);
+    strncpy(proxy.sun_path, path, sizeof(proxy.sun_path));
     if (bind(sock, (struct sockaddr *)&proxy,
             sizeof(struct sockaddr_un)) < 0) {
         do_perror("bind");
-- 
1.8.3.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]