[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] fsdev/virtfs-proxy-helper: Fix improper use o
|
From: |
Aneesh Kumar K.V |
|
Subject: |
Re: [Qemu-trivial] [PATCH] fsdev/virtfs-proxy-helper: Fix improper use of negative value |
|
Date: |
Mon, 16 Mar 2015 11:52:41 +0530 |
|
User-agent: |
Notmuch/0.19+30~gd241a48 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Shannon Zhao <address@hidden> writes:
> It's detected by coverity. Check the return value of proxy_marshal.
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
Applied
> ---
> fsdev/virtfs-proxy-helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index c1da2d7..bf2e5f3 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -262,6 +262,9 @@ static int send_status(int sockfd, struct iovec *iovec,
> int status)
> */
> msg_size = proxy_marshal(iovec, 0, "ddd", header.type,
> header.size, status);
> + if (msg_size < 0) {
> + return msg_size;
> + }
> retval = socket_write(sockfd, iovec->iov_base, msg_size);
> if (retval < 0) {
> return retval;
> --
> 1.8.3.1