[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 22/24] elf-loader: Fix truncation warning from cove
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 22/24] elf-loader: Fix truncation warning from coverity |
Date: |
Thu, 19 Mar 2015 12:05:40 +0300 |
From: Stefan Weil <address@hidden>
Coverity reports a truncation due to cast operation on operand
reltab->sh_size from 64 bits to 32 bits for calls of load_at.
Fix the types of the function arguments to match their use in
function load_at: the offset is used for lseek which takes an
off_t parameter, the size is used for g_malloc and read.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/core/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/loader.c b/hw/core/loader.c
index 76d8aca..d4c441f 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -267,7 +267,7 @@ int load_aout(const char *filename, hwaddr addr, int max_sz,
/* ELF loader */
-static void *load_at(int fd, int offset, int size)
+static void *load_at(int fd, off_t offset, size_t size)
{
void *ptr;
if (lseek(fd, offset, SEEK_SET) < 0)
--
2.1.4
- [Qemu-trivial] [PULL 18/24] vl: fix resource leak with monitor_fdset_add_fd, (continued)
- [Qemu-trivial] [PULL 18/24] vl: fix resource leak with monitor_fdset_add_fd, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 24/24] qga/commands-posix: Fix resource leak, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 08/24] Fix remaining warnings from Sparse (void return), Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 01/24] cris: remove unused cris_cond15 declarations, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 06/24] target-mips: Fix warning from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 20/24] Fix typos in comments, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 12/24] qmp: Drop unused .user_print from command definitions, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 10/24] target-moxie: Fix warnings from Sparse (one-bit signed bitfield), Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 19/24] qtest/ahci: Fix a bit mask expression, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 05/24] arm/nseries: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 22/24] elf-loader: Fix truncation warning from coverity,
Michael Tokarev <=
- [Qemu-trivial] [PULL 02/24] backends: Fix warning from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 17/24] smbios: add max speed comdline option for type-17 (meory device) structure, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 04/24] omap: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 13/24] arm: fix memory leak, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 23/24] elf-loader: Add missing error handling for call of lseek, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 11/24] hmp: Fix definition of command quit, Michael Tokarev, 2015/03/19
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/24] Trivial patches for 2015-03-19, Peter Maydell, 2015/03/19