[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 23/24] elf-loader: Add missing error handling for c
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 23/24] elf-loader: Add missing error handling for call of lseek |
Date: |
Thu, 19 Mar 2015 12:05:41 +0300 |
From: Stefan Weil <address@hidden>
This fixes a warning from Coverity.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
include/hw/elf_ops.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
index 16a627b..bd71968 100644
--- a/include/hw/elf_ops.h
+++ b/include/hw/elf_ops.h
@@ -315,7 +315,9 @@ static int glue(load_elf, SZ)(const char *name, int fd,
glue(load_symbols, SZ)(&ehdr, fd, must_swab, clear_lsb);
size = ehdr.e_phnum * sizeof(phdr[0]);
- lseek(fd, ehdr.e_phoff, SEEK_SET);
+ if (lseek(fd, ehdr.e_phoff, SEEK_SET) != ehdr.e_phoff) {
+ goto fail;
+ }
phdr = g_malloc0(size);
if (!phdr)
goto fail;
--
2.1.4
- [Qemu-trivial] [PULL 20/24] Fix typos in comments, (continued)
- [Qemu-trivial] [PULL 20/24] Fix typos in comments, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 12/24] qmp: Drop unused .user_print from command definitions, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 10/24] target-moxie: Fix warnings from Sparse (one-bit signed bitfield), Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 19/24] qtest/ahci: Fix a bit mask expression, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 05/24] arm/nseries: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 22/24] elf-loader: Fix truncation warning from coverity, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 02/24] backends: Fix warning from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 17/24] smbios: add max speed comdline option for type-17 (meory device) structure, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 04/24] omap: Fix warnings from Sparse, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 13/24] arm: fix memory leak, Michael Tokarev, 2015/03/19
- [Qemu-trivial] [PULL 23/24] elf-loader: Add missing error handling for call of lseek,
Michael Tokarev <=
- [Qemu-trivial] [PULL 11/24] hmp: Fix definition of command quit, Michael Tokarev, 2015/03/19
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/24] Trivial patches for 2015-03-19, Peter Maydell, 2015/03/19