qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] translate-all: remove superfluous #ifdef FOO


From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH] translate-all: remove superfluous #ifdef FOO || 1
Date: Sat, 21 Mar 2015 15:28:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0


On 21/03/2015 07:25, Emilio G. Cota wrote:
> It always evaluates to true.
> 
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  translate-all.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
>      p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
>      invalidate_page_bitmap(p);
>  
> -#if defined(TARGET_HAS_SMC) || 1
> -
>  #if defined(CONFIG_USER_ONLY)
>      if (p->flags & PAGE_WRITE) {
>          target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
>          tlb_protect_code(page_addr);
>      }
>  #endif
> -
> -#endif /* TARGET_HAS_SMC */
>  }
>  
>  /* add a new TB and link it to the physical page tables. phys_page2 is
> 

You are removing the last use of TARGET_HAS_SMC, please remove the
definition as well.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]