Re: [Qemu-trivial] [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

[Peter Maydell]

On 1 April 2015 at 22:14, Paolo Bonzini <address@hidden> wrote:
>
>
> On 01/04/2015 23:06, John Snow wrote:
>>
>> if (qemu == NULL) {
>>   fprintf(stderr, "...");
>>   g_assert_not_reached();
>> }
>>
>> Though that does read a little strangely. ("Here's a nice error message
>> for something we are asserting will never happen.")
>
> Just "exit(1);" then.  :)
>
> Good idea, this is annoying.

Also irritating is the way it silently requires
the binary to have a name in the shape it was
expecting, which can catch you out if you were
trying to set it to a wrapper shell script that
invokes valgrind or something...

-- PMM