qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h


From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h
Date: Wed, 01 Jul 2015 18:09:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Gerd Hoffmann <address@hidden> writes:

> On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote:
>> On 30 June 2015 at 10:09, Gerd Hoffmann <address@hidden> wrote:
>> > Signed-off-by: Gerd Hoffmann <address@hidden>
>> > ---
>> >  include/qemu/option.h   | 2 +-
>> >  include/qemu/typedefs.h | 1 +
>> >  2 files changed, 2 insertions(+), 1 deletion(-)
>> 
>> I don't object necessarily, but it would be nice if the
>> commit message said what the rationale for the change was...
>
> Build failure, with not-yet submitted patches,
> due to QemuOpts being undeclared.

Recommend to post it right before a patch that breaks without it,
because that makes explaining why easier.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]