[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] ide: coverity touchups
From: |
John Snow |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] ide: coverity touchups |
Date: |
Mon, 13 Jul 2015 15:41:40 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 07/13/2015 03:40 PM, Peter Maydell wrote:
> On 13 July 2015 at 20:26, John Snow <address@hidden> wrote:
>> Just a handful of casts to quiet coverity up.
>>
>> s->ports should never exceed 32, but coverity doesn't know that.
>> ncq_tfs->sector_count should also never exceed 64K.
>
> Personally I tend to mark that kind of thing as a false
> positive in the coverity UI and move on...
>
> -- PMM
>
Either way; Paolo pinged me about the NCQ one so I figured I'd just do it.
*shrug*