[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.4-rc3 2/3] hw/acpi/ich9: cl
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.4-rc3 2/3] hw/acpi/ich9: clean up stale comment about KVM not supporting SMM |
Date: |
Mon, 27 Jul 2015 11:43:29 +0200 |
On Fri, 24 Jul 2015 20:16:01 +0200
Laszlo Ersek <address@hidden> wrote:
> Commit fba72476c6 ("ich9: add smm_enabled field and arguments") detached
> SMM availability from kvm_enabled(). However, the comment in pm_reset()
> was not updated; let's do it now.
>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: address@hidden
> Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> hw/acpi/ich9.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index 8da5a2d..1c7fcfa 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -223,8 +223,7 @@ static void pm_reset(void *opaque)
>
> pm->smi_en = 0;
> if (!pm->smm_enabled) {
> - /* Mark SMM as already inited to prevent SMM from running. KVM does
> not
> - * support SMM mode. */
> + /* Mark SMM as already inited to prevent SMM from running. */
> pm->smi_en |= ICH9_PMIO_SMI_EN_APMC_EN;
> }
> pm->smi_en_wmask = ~0;