[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] opts: produce valid command l
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print |
Date: |
Thu, 20 Aug 2015 16:57:23 +0200 |
On Tue, Jul 7, 2015 at 4:42 PM, Kővágó, Zoltán <address@hidden> wrote:
> This will let us print options in a format that the user would actually
> write it on the command line (foo=bar,baz=asd,etc=def), without
> prepending a spurious comma at the beginning of the list, or quoting
> values unnecessarily. This patch provides the following changes:
> * write and id=, if the option has an id
you can remove the first "and" here
> * do not print separator before the first element
> * do not quote string arguments
> * properly escape commas (,) for QEMU
Reviewed-by: Marc-André Lureau <address@hidden>
--
Marc-André Lureau
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print,
Marc-André Lureau <=