[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Add another sanity check to smp_
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Add another sanity check to smp_parse() function |
|
Date: |
Wed, 26 Aug 2015 13:02:09 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 22, 2015 at 03:59:50PM +0200, Thomas Huth wrote:
> The code in smp_parse already checks the topology information for
> sockets * cores * threads < cpus and bails out with an error in
> that case. However, it is still possible to supply a bad configuration
> the other way round, e.g. with:
>
> qemu-system-xxx -smp 4,sockets=1,cores=4,threads=2
>
> QEMU then still starts the guest, with topology configuration that
> is rather incomprehensible and likely not what the user wanted.
> So let's add another check to refuse such wrong configurations.
>
> Signed-off-by: Thomas Huth <address@hidden>
Applied to the x86 tree. Thanks!
--
Eduardo