Re: [Qemu-trivial] [PATCH v3 6/9] arm: clarify the use of muldiv64()

[Peter Maydell]

On 1 September 2015 at 12:23, Laurent Vivier <address@hidden> wrote:
>
>
> On 01/09/2015 13:17, Peter Maydell wrote:
>> On 27 August 2015 at 20:33, Laurent Vivier <address@hidden> wrote:
>>> +#define ARM_CPU_FREQ 1000000000 /* FIXME: 1 GHz, should be configurable */
>>
>> LL suffix for large constants, please.
>
> In fact, I didn't put the LL suffix to not force the use of a 64bit on a
> 32bit machines. Moreover in muldiv64() it is used as a 32bit value.
>
> But if you think it is better, I will. Have I to resend the whole series
> or only this patch ? Perhaps the commiter can edit it ?

Oh, you're right, it's a 32-bit value. I take back my suggestion.

thanks
-- PMM