[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] add macro file for coccinelle
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] add macro file for coccinelle |
|
Date: |
Tue, 08 Sep 2015 15:08:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
>> > +/* From qemu/compiler.h */
>> > +#define QEMU_GNUC_PREREQ(maj, min) 1
>> > +#define QEMU_NORETURN __attribute__ ((__noreturn__))
>> > +#define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
>> > +#define QEMU_SENTINEL __attribute__((sentinel))
>> > +#define QEMU_ARTIFICIAL __attribute__((always_inline, artificial))
>> > +#define QEMU_PACKED __attribute__((gcc_struct, packed))
>> > +
>> > +#define cat(x,y) x ## y
>> > +#define cat2(x,y) cat(x,y)
>>
>> Why not reuse glue()?
>
> Because the duplication is already in compiler.h, which should
> use glue() instead of cat2(). Separate patch IMHO, but thanks
> for noticing. :-)
The separate patch is commit 24134c4 :)