[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] trace/simple: Fix warning and wr
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] trace/simple: Fix warning and wrong trace file name for MinGW |
|
Date: |
Mon, 28 Sep 2015 09:06:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/28/2015 02:26 AM, Stefan Weil wrote:
>> Can you explain why osdep.h's
>>
>> #define FMT_pid "%" PRId64
>>
>> is appropriate for Windows?
>
> Don't blame me for any strangeness which you might find in Windows. :-)
>
> Mingw-w64 sys/types.h defines pid_t to be either an int or an __int64.
> FMT_pid must match these definitions.
>
> But getpid returns an int, not a pid_t...
Can we 1) file a bug against mingw for their buggy getpid(), and 2)
write a wrapper that makes getpid() always return pid_t in the meantime?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature