[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 5/5] linux-user/syscall: Replace
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 5/5] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup |
Date: |
Thu, 8 Oct 2015 17:32:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/08/2015 01:35 PM, Thomas Huth wrote:
> No need to use g_malloc0 to zero the memory if we memcpy to
> the whole buffer afterwards anyway. Actually, there is even
> a function which combines both steps, g_memdup, so let's use
> this function here instead.
>
> Cc: Riku Voipio <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> linux-user/syscall.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 98b5766..f2ada0a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5325,8 +5325,7 @@ static abi_long do_open_by_handle_at(abi_long mount_fd,
> abi_long handle,
> return -TARGET_EFAULT;
> }
>
> - fh = g_malloc0(total_size);
> - memcpy(fh, target_fh, total_size);
> + fh = g_memdup(target_fh, total_size);
> fh->handle_bytes = size;
> fh->handle_type = tswap32(target_fh->handle_type);
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature