[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] object_new_with_type: remove redundant code
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] object_new_with_type: remove redundant code |
|
Date: |
Fri, 06 Nov 2015 11:11:01 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
05.11.2015 08:16, Cao jin wrote:
> g_assert & type_initialize are called in object_initialize_with_type
object_new_with_type() is a separate QOM API function. If we're
to rely on other functions calling it to check for parameters,
we should probably remove it from public API and make it static.
And yes, I'm aware of the fact that currently object_new_with_type()
is only called from object_initialize_with_type(). This is not a
good reason to drop the check/init, since object_new_with_type()
remains a published API and might be used in other places in the
future.
Thanks,
/mjt