qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't all


From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators
Date: Fri, 18 Dec 2015 14:08:22 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

Am 18.12.2015 um 13:59 schrieb Peter Maydell:
> The checkpatch.pl script has a special case to permit the following
> operators to have no spaces around them:
>  <<  >>  &  ^  |  +  -  *  /  %
> 
> QEMU style prefers all operators to consistently have spacing around
> them, so remove this special case handling. This avoids reviewers
> having to manually note it during code review.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> I actually thought failing to point out the lack of spaces was
> a checkpatch parsing bug until I looked in the source and found it
> was deliberate...
> 
> I say "QEMU style prefers", but possibly what I actually mean is
> "I prefer" ? Does anybody want to defend the unspaced versions?


I don't. Therefore

Reviewed-by: Stefan Weil <address@hidden>

Cc'ing QEMU Trivial, maybe it can be applied there.


> 
>  scripts/checkpatch.pl | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b0f6e11..efca817 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1890,19 +1890,6 @@ sub process {
>                                               ERROR("space prohibited after 
> that '$op' $at\n" . $hereptr);
>                                       }
>  
> -
> -                             # << and >> may either have or not have spaces 
> both sides
> -                             } elsif ($op eq '<<' or $op eq '>>' or
> -                                      $op eq '&' or $op eq '^' or $op eq '|' 
> or
> -                                      $op eq '+' or $op eq '-' or
> -                                      $op eq '*' or $op eq '/' or
> -                                      $op eq '%')
> -                             {
> -                                     if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
> -                                             ERROR("need consistent spacing 
> around '$op' $at\n" .
> -                                                     $hereptr);
> -                                     }
> -
>                               # A colon needs no spaces before when it is
>                               # terminating a case value or a label.
>                               } elsif ($opv eq ':C' || $opv eq ':L') {
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]