[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] Use macro instead of plain te

From: Cao jin
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] Use macro instead of plain text
Date: Sun, 20 Dec 2015 18:16:47 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

Hi Peter,

Thanks for the explanation, it make me aware that why there are lots of "plain_text_for_device":)

forget it please.

On 12/18/2015 09:01 PM, Peter Maydell wrote:
On 18 December 2015 at 12:52, Markus Armbruster <address@hidden> wrote:
Cao jin <address@hidden> writes:

There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it
is missed.

I suspect there are more instances of the same problem.

Not sure how interested we are in consistent use of these macros...

In a lot of cases we'd need to find somewhere appropriate to put the
TYPE_* macro which might well mean creating a new header file just
for the purpose. That seems like overkill...

-- PMM

Yours Sincerely,

Cao Jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]