Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] linux-user: enable sigaltstack for all architectures

[Peter Maydell]

On 29 December 2015 at 09:51, Michael Tokarev <address@hidden> wrote:
> There is no reason to limit sigaltstack syscall to just a few
> architectures and pretend it is not implemented for others.
>
> If some architecture is not ready for this, that architecture
> should be fixed instead.
>
> This fixes LP#1516408.
>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
> This patch depends on a previous patch I sent, "unicore32: convert
> get_sp_from_cpustate from macro to inline", or else unicore32-user
> wont build.
> ---
>  linux-user/syscall.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 6c64ba6..3ceb3e2 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8292,14 +8292,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>          break;
>      }
>      case TARGET_NR_sigaltstack:
> -#if defined(TARGET_I386) || defined(TARGET_ARM) || defined(TARGET_MIPS) || \
> -    defined(TARGET_SPARC) || defined(TARGET_PPC) || defined(TARGET_ALPHA) || 
> \
> -    defined(TARGET_M68K) || defined(TARGET_S390X) || defined(TARGET_OPENRISC)
>          ret = do_sigaltstack(arg1, arg2, get_sp_from_cpustate((CPUArchState 
> *)cpu_env));
>          break;
> -#else
> -        goto unimplemented;
> -#endif
>
>  #ifdef CONFIG_SENDFILE
>      case TARGET_NR_sendfile:

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM