[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 14/19] scripts/checkpatch.pl: Don't allow special c
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 14/19] scripts/checkpatch.pl: Don't allow special cases of unspaced operators |
Date: |
Mon, 11 Jan 2016 11:41:53 +0300 |
From: Peter Maydell <address@hidden>
The checkpatch.pl script has a special case to permit the following
operators to have no spaces around them:
<< >> & ^ | + - * / %
QEMU style prefers all operators to consistently have spacing around
them, so remove this special case handling. This avoids reviewers
having to manually note it during code review.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
scripts/checkpatch.pl | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b0f6e11..efca817 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1890,19 +1890,6 @@ sub process {
ERROR("space prohibited after
that '$op' $at\n" . $hereptr);
}
-
- # << and >> may either have or not have spaces
both sides
- } elsif ($op eq '<<' or $op eq '>>' or
- $op eq '&' or $op eq '^' or $op eq '|'
or
- $op eq '+' or $op eq '-' or
- $op eq '*' or $op eq '/' or
- $op eq '%')
- {
- if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
- ERROR("need consistent spacing
around '$op' $at\n" .
- $hereptr);
- }
-
# A colon needs no spaces before when it is
# terminating a case value or a label.
} elsif ($opv eq ':C' || $opv eq ':L') {
--
2.1.4
- [Qemu-trivial] [PULL 00/19] Trivial patches for 2016-01-11, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 07/19] xen/Makefile.objs: simplify, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 06/19] crypto: Fix typo in example, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 01/19] unicore32: convert get_sp_from_cpustate from macro to inline, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 08/19] configure: fix trace backend check, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 05/19] MAINTAINERS: Add the correct device_tree.h file, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 14/19] scripts/checkpatch.pl: Don't allow special cases of unspaced operators,
Michael Tokarev <=
- [Qemu-trivial] [PULL 09/19] hw/misc/edu: Convert to realize(), Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 04/19] iscsi: fix readcapacity error message, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 15/19] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 13/19] PCI Bonito: QOMify and cleanup, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 16/19] hw/ide: Remove superfluous return statements, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 19/19] hw/s390x: Remove superfluous return statements, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 18/19] hw/core/qdev: Remove superfluous return statement, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 17/19] hw/acpi: Remove superfluous return statement, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 10/19] Add missing syscall nrs. according to more recent Linux kernels, Michael Tokarev, 2016/01/11
- [Qemu-trivial] [PULL 11/19] gt64120: convert to realize(), Michael Tokarev, 2016/01/11