[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [PATCH] Keep pty slave file descriptor open until the master is closed |
|
Date: |
Mon, 11 Jan 2016 10:13:36 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 11/01/2016 09:33, Michael Tokarev wrote:
> 11.12.2015 14:29, Ashley Jonathan wrote:
>> I have experienced a minor difficulty using QEMU with the "-serial pty"
>> option:
>>
>> If a process opens the slave pts device, writes data to it, then immediately
>> closes it, the data doesn't reliably get delivered to the emulated serial
>> port. This seems to be because a read of the master pty device returns EIO
>> on Linux if no process has the pts device open, even when data is waiting
>> "in the pipe".
>>
>> A fix seems to be for QEMU to keep the pts file descriptor open until the
>> pty is closed, as per the below patch.
>
> The patch looks fine, so
>
> Reviewed-by: Michael Tokarev <address@hidden>
>
> but I'd love to have an ACK from the maintainer about this one,
> or for it to pick it up.
Ok, I'll pick it up after I've read up a bit more on PTYs.
Paolo