[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the d

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support
Date: Wed, 3 Feb 2016 19:05:45 +0000

On 3 February 2016 at 18:54, Alex Bennée <address@hidden> wrote:
> It preserves the old behaviour (and the general behaviour of DEBUG_FOO
> going to stderr). However I'm happy to make it default to using the log
> output.
> It does raise the question of if we should just enable the debugging by
> default?

Not without thinking carefully about it. This is programmer
debug code for figuring out what's happening in a performance
sensitive bit of code. "Just print to stderr" is the classic
way to do this, and I don't think we should just convert that
into userfacing trace.

There may be useful user facing trace we can do of TLB
operations but I wouldn't assume that our current debug
printfs are it.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]