[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] w32: include winsock2.h before windows.h

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] w32: include winsock2.h before windows.h
Date: Tue, 9 Feb 2016 14:38:56 +0000

On 9 February 2016 at 14:37, Paolo Bonzini <address@hidden> wrote:
> On 09/02/2016 15:28, Peter Maydell wrote:
>> On 9 February 2016 at 14:21, Daniel P. Berrange <address@hidden> wrote:
>>> > On Tue, Feb 09, 2016 at 03:16:57PM +0100, Paolo Bonzini wrote:
>>> > include/qemu/sockets.h also has windows.h included before winsock2.h
>>> >
>>> > Presumably it didn't cause a failure for you because everything using
>>> > sockets.h already pulls in osdep.h. A reason to prune sockets.h
>>> > headers perhaps.
>> More generally we could prune anything including windows.h manually
>> (there are a dozen or so .c and .h files doing that currently).
> I honestly do not have time to work on this. :(

That's OK, I currently have a bunch of include file cleanups
going through so one more won't hurt too much :-)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]