[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] w32: include winsock2.h before w

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h
Date: Tue, 9 Feb 2016 17:06:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 09/02/2016 17:03, Stefan Weil wrote:
> Reviewed-by: Stefan Weil <address@hidden>
> Without that patch, windows.h will include winsock.h
> (which conflicts with winsock2.h) when compiling sdl.c.
> Normally we define WIN32_LEAN_AND_MEAN, and
> windows.h won't include winsock.h.
> include/ui/sdl2.h and ui/sdl.c undefine that macro,
> so the order of the include files is important.
> Without testing this, I think that Paolo's patch is needed
> since commit e16f4c8770b73f530dad842a31298963b6c7e41d.

That also explains why only that file complains.  Thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]