[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] doc/memory.txt: fix typo

From: Cao jin
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] doc/memory.txt: fix typo
Date: Fri, 26 Feb 2016 10:36:00 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 02/25/2016 10:24 PM, Peter Maydell wrote:
On 25 February 2016 at 13:30, Cao jin <address@hidden> wrote:

You're certainly right that the documentation as it stands is wrong.
I don't think this is a simple typo though. Probably what happened
was that when the API was being designed it started off with an
'unaligned' field, and then later the field name and semantics
were changed but the docs weren't updated to match. My point was
that just changing the name without looking at the behaviour we're
actually implementing isn't correct.

Totally agree with the point.

I admit that, the description like ".valid.unaligned specifies that the
device only accepts naturally aligned accesses" looks very confusing. But
from the only caller memory_region_access_valid(), I think the original
maybe not quite good? how about this:

/.valid.unaligned specifies that the device accepts unaligned accesses.  If
false, Unaligned accesses invoke device and bus specific behaviour/

I would suggest:

   - .valid.unaligned specifies that the *device being modelled*
     supports unaligned accesses; if false, unaligned accesses will
     invoke the appropriate bus or CPU specific behaviour.

Does better. I want to pack this into a trivial patch first, because the original is not easy to read & understand

(the idea being to make the text parallel to the existing
.impl.unaligned docs so it's clear what the difference is.)

-- PMM


Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]