[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] pxb: cleanup

From: Marcel Apfelbaum
Subject: Re: [Qemu-trivial] [PATCH] pxb: cleanup
Date: Tue, 1 Mar 2016 11:50:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 03/01/2016 11:45 AM, Cao jin wrote:
Signed-off-by: Cao jin <address@hidden>
BTW: this doc seems little out of date, since pxb has already support Q35.


Yes, you are right, but we use a different device, pxb-pcie.
I will send a doc update about it, thanks for reminding me,

  docs/pci_expander_bridge.txt        | 6 +++---
  hw/pci-bridge/pci_expander_bridge.c | 2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/pci_expander_bridge.txt b/docs/pci_expander_bridge.txt
index e7c8fe9..3675027 100644
--- a/docs/pci_expander_bridge.txt
+++ b/docs/pci_expander_bridge.txt
@@ -24,8 +24,8 @@ A detailed command line would be:
  -object memory-backend-ram,size=1024M,policy=bind,host-nodes=0,id=ram-node0 
-numa node,nodeid=0,cpus=0,memdev=ram-node0
  -object memory-backend-ram,size=1024M,policy=bind,host-nodes=1,id=ram-node1 
-numa node,nodeid=1,cpus=1,memdev=ram-node1
  -device pxb,id=bridge1,bus=pci.0,numa_node=1,bus_nr=4 -netdev user,id=nd 
-device e1000,bus=bridge1,addr=0x4,netdev=nd
--device pxb,id=bridge2,bus=pci.0,numa_node=0,bus_nr=8, -device 
--device pxb,id=bridge3,bus=pci.0,bus_nr=40, -drive 
if=none,id=drive0,file=[img] -device 
+-device pxb,id=bridge2,bus=pci.0,numa_node=0,bus_nr=8 -device 
+-device pxb,id=bridge3,bus=pci.0,bus_nr=40 -drive if=none,id=drive0,file=[img] 
-device virtio-blk-pci,drive=drive0,scsi=off,bus=bridge3,addr=1

  Here you have:
   - 2 NUMA nodes for the guest, 0 and 1. (both mapped to the same NUMA node in 
host, but you can and should put it in different host NUMA nodes)
@@ -43,7 +43,7 @@ Implementation
  The PXB is composed by:
  - HostBridge (TYPE_PXB_HOST)
-  The host bridge allows to register and query the PXB's rPCI root bus in QEMU.
+  The host bridge allows to register and query the PXB's PCI root bus in QEMU.
    It is a regular PCI Device that resides on the piix host-bridge bus and its 
bus uses the same PCI domain.
    However, the bus behind is exposed through ACPI as a primary PCI bus and 
starts a new PCI hierarchy.
diff --git a/hw/pci-bridge/pci_expander_bridge.c 
index d23b8da..5e7e546 100644
--- a/hw/pci-bridge/pci_expander_bridge.c
+++ b/hw/pci-bridge/pci_expander_bridge.c
@@ -283,7 +283,7 @@ static void pxb_dev_exitfn(PCIDevice *pci_dev)

  static Property pxb_dev_properties[] = {
-    /* Note: 0 is not a legal a PXB bus number. */
+    /* Note: 0 is not a legal PXB bus number. */
      DEFINE_PROP_UINT8("bus_nr", PXBDev, bus_nr, 0),
      DEFINE_PROP_UINT16("numa_node", PXBDev, numa_node, NUMA_NODE_UNASSIGNED),

Reviewed-by: Marcel Apfelbaum <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]