[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 2/2] [RESENT-INLINE] Remove unnecessary CONFIG_EVE
From: |
Christopher Friedt |
Subject: |
[Qemu-trivial] [PATCH 2/2] [RESENT-INLINE] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link |
Date: |
Mon, 2 May 2016 21:01:05 -0400 |
The file ivshmem.c unconditionally references event_notifier_init_fd() in
util/event_notifier-posix.c, even if CONFIG_EVENTFD is not defined. On
platforms where CONFIG_POSIX is defined, but CONFIG_EVENTFD is not defined,
that results in an undefined symbol referenced from ivshmem.c and the link
fails. That applies to Mac OS X, but possibly other BSD-based distros.
Note: there is nothing specific to eventfd inside and event_notifier_init()
also fails unconditionally if CONFIG_EVENTFD is not defined.
Signed-off-by: Christopher Friedt <address@hidden>
---
util/event_notifier-posix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c
index c1f0d79..c9bb34d 100644
--- a/util/event_notifier-posix.c
+++ b/util/event_notifier-posix.c
@@ -21,7 +21,6 @@
#include <sys/eventfd.h>
#endif
-#ifdef CONFIG_EVENTFD
/*
* Initialize @e with existing file descriptor @fd.
* @fd must be a genuine eventfd object, emulation with pipe won't do.
@@ -31,7 +30,6 @@ void event_notifier_init_fd(EventNotifier *e, int fd)
e->rfd = fd;
e->wfd = fd;
}
-#endif
int event_notifier_init(EventNotifier *e, int active)
{
--
2.6.4 (Apple Git-63)