[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EV
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Remove unnecessary CONFIG_EVENTFD preprocessor conditional to satisfy link
Mon, 2 May 2016 21:25:26 -0400
On Mon, May 2, 2016 at 9:18 PM, Peter Maydell <address@hidden> wrote:
> On 3 May 2016 at 02:14, Christopher Friedt <address@hidden> wrote:
>> On Mon, May 2, 2016 at 9:01 PM, Peter Maydell <address@hidden> wrote:
>>> [ccing somebody else who ran into this, since I've figured out why.]
>>> On 3 May 2016 at 01:47, Christopher Friedt <address@hidden> wrote:
>>>> The file ivshmem.c unconditionally references event_notifier_init_fd()
>>>> in util/event_notifier-posix.c, even if CONFIG_EVENTFD is not defined.
>>> Yes, but ivshmem.c is only built if CONFIG_IVSHMEM, and
>>> CONFIG_IVSHMEM is set (in default-configs/pci.mak) to CONFIG_EVENTFD.
>>> So if CONFIG_EVENTFD is not defined then we should never build ivshmem.o.
>>> The problem here is that you've run into a bug in QEMU's makefiles,
>> That would explain things.
> Hmm. (Is it set the same for every config-devices.mak for
> every target you're trying to build?)
Ack - too late! I manually removed all of the *-softmmu/ directories
after doing a make clean, because they were still hanging around.
Rebuilding worked fine without PATCH 2/2.
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] Use libtool instead of ar to create static libraries on Darwin., (continued)