Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

[Peter Maydell]

On 4 May 2016 at 01:07, Christopher Friedt <address@hidden> wrote:
>
> On May 3, 2016 9:50 AM, "Christopher Friedt" <address@hidden> wrote:
>>
>> On Tue, May 3, 2016 at 3:06 AM, Richard Henderson <address@hidden> wrote:
>> > On 05/02/2016 03:10 PM, Christopher Friedt wrote:
>> >>
>> >>  %.a:
>> >> +ifdef CONFIG_DARWIN
>> >> +       $(call quiet-command,rm -f $@ && libtool -static -o $@ $^,"
>> >> libtool    $(TARGET_DIR)$@")
>> >> +else
>> >>         $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR
>> >> $(TARGET_DIR)$@")
>> >> +endif
>> >>
>> >
>> > Does it work to use libtool -static everywhere?
>
> One possibility for future-proofing the link stage that applies to most
> (all?) platforms that Qemu runs on would be to switch to libtool for all
> arch's and just adjust the "libtool flags" as necessary.
>
> Would require checking for libtool.

This is more complicated than we need. OSX "libtool" and GNU
"libtool" are really completely different things. We don't
(these days) do anything that we need GNU libtool for, so
there's no need to depend on it or use it optionally -- we should
just use "ar". If we need to special case the "program for creating
static libraries" for OSX that's annoying but we can do that.

thanks
-- PMM