[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2] qdict: fix unbounded stack warning for qdi

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries
Date: Fri, 6 May 2016 21:39:37 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0

22.03.2016 18:39, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>> Here we use one g_strdup_printf() to replace the two stack allocated
>> array, considering it's more convenient, safe, and as long as it's
>> called rarely only when quorum device opens. This will remove the
>> unbound stack warning when compiling with "-Wstack-usage=1000000".
>> Reviewed-by:   Eric Blake <address@hidden>
>> Signed-off-by: Peter Xu <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> I lack the time to take this through my tree before my Easter vacation.
> Nominating for qemu-trivial, assuming Luiz doesn't mind.

(Finally) applied to -trivial, thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]