qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE


From: Corey Minyard
Subject: Re: [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE
Date: Wed, 18 May 2016 09:36:47 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

On 05/18/2016 05:59 AM, Cao jin wrote:
Replace tab with 4 spaces; brace the indented statement.

Thanks, I think I have my editor set up to avoid the tab/space issue from
now on.  I'm going to have to handle kernel/qemu switching in my brain
for the brace issue.

Acked-by: Corey Minyard <address@hidden>

Signed-off-by: Cao jin <address@hidden>
---
  hw/nvram/fw_cfg.c | 17 +++++++++++------
  1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 999f480..826181a 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -728,15 +728,20 @@ static int get_fw_cfg_order(FWCfgState *s, const char 
*name)
  {
      int i;
- if (s->fw_cfg_order_override > 0)
-       return s->fw_cfg_order_override;
+    if (s->fw_cfg_order_override > 0) {
+        return s->fw_cfg_order_override;
+    }
for (i = 0; i < ARRAY_SIZE(fw_cfg_order); i++) {
-       if (fw_cfg_order[i].name == NULL)
-           continue;
-       if (strcmp(name, fw_cfg_order[i].name) == 0)
-           return fw_cfg_order[i].order;
+        if (fw_cfg_order[i].name == NULL) {
+            continue;
+        }
+
+        if (strcmp(name, fw_cfg_order[i].name) == 0) {
+            return fw_cfg_order[i].order;
+        }
      }
+
      /* Stick unknown stuff at the end. */
      error_report("warning: Unknown firmware file in legacy mode: %s\n", name);
      return FW_CFG_ORDER_OVERRIDE_LAST;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]