[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user, trivial: display "0x
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user, trivial: display "0x%x" instead of "0x%d" |
Date: |
Mon, 20 Jun 2016 10:49:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/20/2016 03:51 AM, Laurent Vivier wrote:
> Display an exception number, generally defined as an hexadecimal
> number (for instance, EXCP_HLT is 0x10001).
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> Resent to fix qemu-trivial email address.
>
> linux-user/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
Can you also fix the occurrence of 0x%d in trace-events, for
mhp_pc_dimm_assigned_slot()? (Or whatever file it lands in after the
trace-events split pull request)
> diff --git a/linux-user/main.c b/linux-user/main.c
> index b9a4e0e..c79f5cb 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2036,7 +2036,7 @@ void cpu_loop(CPUPPCState *env)
> /* just indicate that signals should be handled asap */
> break;
> default:
> - cpu_abort(cs, "Unknown exception 0x%d. Aborting\n", trapnr);
> + cpu_abort(cs, "Unknown exception 0x%x. Aborting\n", trapnr);
> break;
> }
> process_pending_signals(env);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature