[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STY

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE
Date: Thu, 14 Jul 2016 08:08:58 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 07/14/2016 07:10 AM, Cao jin wrote:
> replace tab with spaces
> Signed-off-by: Cao jin <address@hidden>
> ---
>  async.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Whitespace-only changes are best done as part of a series that is
already touching nearby code for other reasons (depending on the size of
the whitespace changes and on the rest of your patch, it may be okay to
squash the whitespace change in place, or better to split into separate
patches to make review of both patches easier).  Otherwise, it just
makes 'git blame' output dirtier.
> diff --git a/async.c b/async.c
> index 1f9754b..8589017 100644
> --- a/async.c
> +++ b/async.c
> @@ -217,7 +217,7 @@ aio_ctx_check(GSource *source)
>      for (bh = ctx->first_bh; bh; bh = bh->next) {
>          if (!bh->deleted && bh->scheduled) {
>              return true;
> -     }
> +        }

Nothing wrong with the patch itself, and I won't oppose it going in, but
it's generally not worth the effort if nothing else in this file needs

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]