[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STY

From: Cao jin
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE
Date: Fri, 15 Jul 2016 09:48:50 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 07/14/2016 10:08 PM, Eric Blake wrote:
On 07/14/2016 07:10 AM, Cao jin wrote:
replace tab with spaces

Signed-off-by: Cao jin <address@hidden>
  async.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Whitespace-only changes are best done as part of a series that is
already touching nearby code for other reasons (depending on the size of
the whitespace changes and on the rest of your patch, it may be okay to
squash the whitespace change in place, or better to split into separate
patches to make review of both patches easier).  Otherwise, it just
makes 'git blame' output dirtier.

I see.
Since async.c & aio-posix.c are belong to the same maintaiers, so, Fam & Stefan, is it ok to squash this into that "remove useless parameter" patch? If not, we can just forget this one.

Yours Sincerely,

Cao jin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]