[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
From: |
Fam Zheng |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF |
Date: |
Wed, 10 Aug 2016 10:41:55 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 08/01 13:04, Fam Zheng wrote:
> Currently "make address@hidden" has a warning like:
>
> /tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb':
> /tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects
> argument of type 'int', but argument 4 has type 'curl_socket_t {aka long
> long unsigned int}'
> DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> ^
> cc1: all warnings being treated as errors
>
> Cast to int to suppress it.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/curl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index da9f5e8..426fb4d 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -169,7 +169,7 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int
> action,
> state->sock_fd = fd;
> s = state->s;
>
> - DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> + DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
> switch (action) {
> case CURL_POLL_IN:
> aio_set_fd_handler(s->aio_context, fd, false,
> --
> 2.7.4
>
>
Since this is blocking the mingw testing on patchew, I'm taking this in my
tree. Applied to my docker branch:
https://github.com/famz/qemu/tree/docker
Thanks,
Fam