Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and 
exit(EXIT_FAILURE)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3235810 net: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
135fd75 hw: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
e7b6224 error, trace: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
c137ac2 core: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
07288c1 blockdev: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
7b628d1 misc machine: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
6c4967c common: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
7b8ef6f alpha: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
84c70f3 posix: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
c550aba tcg: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
d2b8848 s390: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
f98628c mips: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
2128499 x86: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
ff054fd sh4: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
865df75 sparc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
c443546 pci, virtio: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
624a839 m68k: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
d8e62e0 qemu-user: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
a95c986 replay: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
bc2fa7d tests: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
8ad5b66 graphics: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
086d557 ppc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
f456e5f block: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
2bc700c cris: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
5cacfb6 arm: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
566755c coccinelle: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

=== OUTPUT BEGIN ===
Checking PATCH 1/26: coccinelle: use exit(EXIT_SUCCESS) and 
exit(EXIT_FAILURE)...
Checking PATCH 2/26: arm: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 3/26: cris: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
ERROR: code indent should never use tabs
#64: FILE: tests/tcg/cris/check_glibc_kernelversion.c:115:
+^Iexit(EXIT_SUCCESS);$

ERROR: code indent should never use tabs
#86: FILE: tests/tcg/cris/check_lz.c:48:
+^Iexit(EXIT_SUCCESS);$

ERROR: code indent should never use tabs
#233: FILE: tests/tcg/cris/sys.c:15:
+^Iexit(EXIT_SUCCESS);$

total: 3 errors, 0 warnings, 133 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/26: block: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 5/26: ppc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 6/26: graphics: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 7/26: tests: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 8/26: replay: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 9/26: qemu-user: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 10/26: m68k: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 11/26: pci, virtio: use exit(EXIT_SUCCESS) and 
exit(EXIT_FAILURE)...
Checking PATCH 12/26: sparc: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 13/26: sh4: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 14/26: x86: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 15/26: mips: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 16/26: s390: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 17/26: tcg: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 18/26: posix: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 19/26: alpha: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 20/26: common: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 21/26: misc machine: use exit(EXIT_SUCCESS) and 
exit(EXIT_FAILURE)...
Checking PATCH 22/26: blockdev: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 23/26: core: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 24/26: error, trace: use exit(EXIT_SUCCESS) and 
exit(EXIT_FAILURE)...
Checking PATCH 25/26: hw: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
Checking PATCH 26/26: net: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden