[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] target-lm32: fix LOG_DIS operand order

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] target-lm32: fix LOG_DIS operand order
Date: Wed, 12 Oct 2016 19:19:40 +0100

On 12 October 2016 at 18:15, Michael Walle <address@hidden> wrote:
> The order of most opcodes with immediates was wrong (according to the
> reference manual) in the (debug) logging. Additionally, one operand for the
> andhi instruction was completly wrong. Fix these.
> Signed-off-by: Michael Walle <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

PS: the wcsr disassembly also looks to be wrong:
    LOG_DIS("wcsr r%d, %d\n", dc->r1, dc->csr);
where the manual says this is "wcsr csr, rX"
(separate bug though really).

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]