[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] tests/boot-sector: Use mkste
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] tests/boot-sector: Use mkstemp() to create a unique file name |
|
Date: |
Fri, 14 Oct 2016 10:50:58 +0800 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, 10/11 17:19, Thomas Huth wrote:
> The pxe-test is run for three different targets now (x86_64, i386
> and ppc64), and the bios-tables-test is run for two targets (x86_64
> and i386). But each of the tests is using an invariant name for the
> disk image with the boot sector code - so if the tests are running in
> parallel, there is a race condition that they destroy the disk image
> of a parallel test program. Let's use mkstemp() to create unique
> temporary files here instead - and since mkstemp() is returning an
> integer file descriptor instead of a FILE pointer, we also switch
> the fwrite() and fclose() to write() and close() instead.
>
> Reported-by: Sascha Silbe <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
Tested-by: Fam Zheng <address@hidden>