[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] script/clean-includes: added

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate #include check
Date: Thu, 20 Oct 2016 08:48:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0


On 10/20/2016 04:52 AM, Anand J wrote:
> Added script to check duplicate #include entries. This check will scan
> and print the files in which duplicate #include entries are present.

This appears to be a v2 patch.  But it is missing a 0/2 cover letter,
and mention of v2 in the subject line.  'git format-patch --cover-letter
-v2' will do what you want (as well as git send-email, which understands
all options accepted by format-patch); it's also possible to automate
git to send a cover letter any time you send more than one patch by
using 'git config format.coverLetter auto'.

More patch submission tips at http://wiki.qemu.org/Contribute/SubmitAPatch

> Script might output false positive entries as well. Such entries should
> not be removed. So if it finds any duplicate entries script will
> terminate with an exit status 1. Then each and every file should be
> checked manually and corrected if necessary.
> In order to enable the check use --check-duphead option with
> script/clean-includes.
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Anand J <address@hidden>
> ---
>  scripts/clean-includes | 50 
> +++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 37 insertions(+), 13 deletions(-)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]