[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] tci: Remove invalid assertions
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [PATCH] tci: Remove invalid assertions |
Date: |
Fri, 3 Feb 2017 12:32:33 +0000 |
On 2 February 2017 at 19:56, Stefan Weil <address@hidden> wrote:
> tb_jmp_insn_offset and tb_jmp_reset_offset are pointers
> and cannot be used with ARRAY_SIZE.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> tcg/tci/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tcg/tci/tcg-target.inc.c b/tcg/tci/tcg-target.inc.c
> index 26ee9b1664..b6a15569f8 100644
> --- a/tcg/tci/tcg-target.inc.c
> +++ b/tcg/tci/tcg-target.inc.c
> @@ -566,7 +566,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
> const TCGArg *args,
> case INDEX_op_goto_tb:
> if (s->tb_jmp_insn_offset) {
> /* Direct jump method. */
> - tcg_debug_assert(args[0] < ARRAY_SIZE(s->tb_jmp_insn_offset));
> /* Align for atomic patching and thread safety */
> s->code_ptr = QEMU_ALIGN_PTR_UP(s->code_ptr, 4);
> s->tb_jmp_insn_offset[args[0]] = tcg_current_code_size(s);
> @@ -575,7 +574,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
> const TCGArg *args,
> /* Indirect jump method. */
> TODO();
> }
> - tcg_debug_assert(args[0] < ARRAY_SIZE(s->tb_jmp_reset_offset));
> s->tb_jmp_reset_offset[args[0]] = tcg_current_code_size(s);
> break;
> case INDEX_op_br:
> --
> 2.11.0
Applied to master as a buildfix; thanks.
-- PMM