[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 08/10] sm501: Add support for pan
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 08/10] sm501: Add support for panel layer |
Date: |
Sat, 25 Feb 2017 16:23:25 +0000 |
On 24 February 2017 at 20:38, BALATON Zoltan <address@hidden> wrote:
> On Fri, 24 Feb 2017, Peter Maydell wrote:
>> Please don't change variable names in the middle of a patch that's
>> adding new functionality, it makes the patch harder to review.
>
>
> Where should I do it then? Again another patch?
Yes. Either make it its own patch, or drop the change altogether.
Anything that makes the core "this is making a bug fix or
adding new functionality" patch bigger by adding unnecessary
code change to it makes that patch harder to review.
(Conversely a patch that's just "change this variable name"
is trivially easy to review.)
thanks
-- PMM
[Qemu-trivial] [PATCH 01/10] sm501: Fixed code style and a few typos in comments, BALATON Zoltan, 2017/02/19
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/10] Improvements for sm501 display controller emulation, BALATON Zoltan, 2017/02/23