[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 12/14] lm32: milkymist-tmu2: fix a third integer ov
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 12/14] lm32: milkymist-tmu2: fix a third integer overflow |
Date: |
Tue, 28 Feb 2017 09:44:55 +0300 |
From: Peter Maydell <address@hidden>
Don't truncate the multiplication and do a 64 bit one instead
because the result is stored in a 64 bit variable.
This fixes a similar coverity warning to commits 237a8650d640 and
4382fa655498, in a similar way, and is the final third of the fix for
coverity CID 1167561 (hopefully!).
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Michael Walle <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/display/milkymist-tmu2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c
index 7528665..59120dd 100644
--- a/hw/display/milkymist-tmu2.c
+++ b/hw/display/milkymist-tmu2.c
@@ -293,7 +293,7 @@ static void tmu2_start(MilkymistTMU2State *s)
cpu_physical_memory_unmap(mesh, mesh_len, 0, mesh_len);
/* Write back the OpenGL framebuffer to the QEMU framebuffer */
- fb_len = 2 * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
+ fb_len = 2ULL * s->regs[R_DSTHRES] * s->regs[R_DSTVRES];
fb = cpu_physical_memory_map(s->regs[R_DSTFBUF], &fb_len, 1);
if (fb == NULL) {
glDeleteTextures(1, &texture);
--
2.1.4
- [Qemu-trivial] [PULL 00/14] Trivial patches for 2017-02-28, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 06/14] ide: remove undefined behavior in ide-test, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 01/14] target/s390x: Fix typo, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 13/14] hw/acpi/tco.c: fix tco timer stop, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 08/14] cadence_gem: Remove unused parameter debug message, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 11/14] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 10/14] Update copyright year, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 05/14] CODING_STYLE: Mention preferred comment form, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 14/14] syscall: fixed mincore(2) not failing with ENOMEM, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 09/14] tests/prom-env: Enable the test for the sun4u machine, too, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 12/14] lm32: milkymist-tmu2: fix a third integer overflow,
Michael Tokarev <=
- [Qemu-trivial] [PULL 07/14] register: fix incorrect read mask, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 02/14] softfloat: Use correct type in float64_to_uint64_round_to_zero(), Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 04/14] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet, Michael Tokarev, 2017/02/28
- [Qemu-trivial] [PULL 03/14] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet, Michael Tokarev, 2017/02/28
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/14] Trivial patches for 2017-02-28, Peter Maydell, 2017/02/28