[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 08/23] qga: fix compiler warnings (clang 5)
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 08/23] qga: fix compiler warnings (clang 5) |
Date: |
Sun, 7 May 2017 10:02:11 +0300 |
From: Philippe Mathieu-Daudé <address@hidden>
static code analyzer complain:
qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a
'nonnull' parameter
closedir(dp);
^~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
qga/commands-posix.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ba06be4c86..284ecc6d7e 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2125,9 +2125,11 @@ static void transfer_memory_block(GuestMemoryBlock
*mem_blk, bool sys2memblk,
* we think this VM does not support online/offline memory block,
* any other solution?
*/
- if (!dp && errno == ENOENT) {
- result->response =
- GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED;
+ if (!dp) {
+ if (errno == ENOENT) {
+ result->response =
+ GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_NOT_SUPPORTED;
+ }
goto out1;
}
closedir(dp);
--
2.11.0
- [Qemu-trivial] [PULL 00/23] Trivial patches for 2017-05-07, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 08/23] qga: fix compiler warnings (clang 5),
Michael Tokarev <=
- [Qemu-trivial] [PULL 12/23] use _Static_assert in QEMU_BUILD_BUG_ON, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 11/23] channel-file: fix wrong parameter comments, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 01/23] Remove reduntant qemu: from error functions, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 09/23] util: Use g_malloc/g_free in envlist.c, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 19/23] tests: Ignore another built executable (test-hmp), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 14/23] virtio-blk: Remove useless condition around g_free(), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 06/23] usb-ccid: make ccid_write_data_block() cope with null buffers, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 15/23] hw/core/generic-loader: Fix crash when running without CPU, Michael Tokarev, 2017/05/07