[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] coccinelle: fix typo in comment
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-trivial] [PATCH] coccinelle: fix typo in comment |
|
Date: |
Tue, 16 May 2017 09:35:07 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/15/2017 07:11 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/coccinelle/return_directly.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Did you intend for this to be threaded with your other 'oslib: strip
trailing '\n'...' patch? If so, where's the 0/2 cover letter and proper
subject lines?
At any rate,
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/scripts/coccinelle/return_directly.cocci
> b/scripts/coccinelle/return_directly.cocci
> index 48680f2c2a..4cf50e75ea 100644
> --- a/scripts/coccinelle/return_directly.cocci
> +++ b/scripts/coccinelle/return_directly.cocci
> @@ -1,4 +1,4 @@
> -// replace 'R = X; return R;' with 'return R;'
> +// replace 'R = X; return R;' with 'return X;'
> @@
> identifier VAR;
> expression E;
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature