[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include |
Date: |
Tue, 23 May 2017 17:58:23 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
09.05.2017 02:39, Philippe Mathieu-Daudé wrote:
> "exec/memory.h" already includes it.
I think this sort of include cleanups isn't really necessary.
For a regular include file, it's better to include it if the
.c file in question uses definitions from there, no matter if
other .h files include that header already or not.
Thanks,
/mjt
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/arm/arm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h
> index a3f79d3379..b9c11d3fb8 100644
> --- a/include/hw/arm/arm.h
> +++ b/include/hw/arm/arm.h
> @@ -14,7 +14,6 @@
> #include "exec/memory.h"
> #include "target/arm/cpu-qom.h"
> #include "hw/irq.h"
> -#include "qemu/notify.h"
>
> typedef enum {
> ARM_ENDIANNESS_UNKNOWN = 0,
>
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes, (continued)
[Qemu-trivial] [PATCH 01/11] hw/net: removed obsolete comments, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 05/11] hw/mips: add missing include, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include, Philippe Mathieu-Daudé, 2017/05/08
- Re: [Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include,
Michael Tokarev <=
[Qemu-trivial] [PATCH 04/11] ide/ahci: add missing includes, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 10/11] register: display register prefix (name) since it is available, Philippe Mathieu-Daudé, 2017/05/08