Re: [Qemu-trivial] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available

[Kamil Rytarowski]

On 06.06.2017 09:10, Michael Tokarev wrote:
> 06.06.2017 09:54, Markus Armbruster wrote:
> 
> [ ./configure --disable-linux-user --disable-system --static ]
> 
>> I haven't, but here's a quick guess on what we need to squash into the
>> patch:
>>
>> diff --git a/Makefile b/Makefile
>> index c830d7a..2ef5a78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -469,10 +469,12 @@ ifneq ($(EXESUF),)
>>  qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI)
>>  endif
>>  
>> +ifdef CONFIG_IVSHMEM
>>  ivshmem-client$(EXESUF): $(ivshmem-client-obj-y) $(COMMON_LDADDS)
>>      $(call LINK, $^)
>>  ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) $(COMMON_LDADDS)
>>      $(call LINK, $^)
>> +endif
> 
> This effectively disables building ivshmem executables on this config
> on linux, while previously they were building fine. Hmm..
> 
> /mjt
> 

I've linked qemu with the original patch and:
./configure --disable-linux-user --disable-system --static

I got some warnings, I think they are originated from our libc and are
not related to qemu:
  LINK    sparc64-bsd-user/qemu-sparc64
/usr/lib/libc.a(initfini.o): warning: common of `__ps_strings'
overridden by definition
/usr/lib/crt0.o: warning: defined here
/usr/lib/libc.a(_env.o): warning: multiple common of `environ'
/usr/lib/crt0.o: warning: previous common is here
/usr/lib/libc.a(getprogname.o): warning: common of `__progname'
overridden by definition
/usr/lib/crt0.o: warning: defined here
  LINK    x86_64-bsd-user/qemu-x86_64
/usr/lib/libc.a(initfini.o): warning: common of `__ps_strings'
overridden by definition
/usr/lib/crt0.o: warning: defined here
/usr/lib/libc.a(_env.o): warning: multiple common of `environ'
/usr/lib/crt0.o: warning: previous common is here
/usr/lib/libc.a(getprogname.o): warning: common of `__progname'
overridden by definition
/usr/lib/crt0.o: warning: defined here
  LINK    i386-bsd-user/qemu-i386
/usr/lib/libc.a(initfini.o): warning: common of `__ps_strings'
overridden by definition
/usr/lib/crt0.o: warning: defined here
/usr/lib/libc.a(_env.o): warning: multiple common of `environ'
/usr/lib/crt0.o: warning: previous common is here
/usr/lib/libc.a(getprogname.o): warning: common of `__progname'
overridden by definition
/usr/lib/crt0.o: warning: defined here

I will ask other NetBSD developers about __ps_strings, environ and
__progname.

signature.asc
Description: OpenPGP digital signature