Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available

[Kamil Rytarowski]

On 19.06.2017 09:42, Markus Armbruster wrote:
> Kamil Rytarowski <address@hidden> writes:
> 
>> On 10.06.2017 17:15, Markus Armbruster wrote:
>>> Kamil Rytarowski <address@hidden> writes:
>>>
>>>> On 06.06.2017 16:56, Kamil Rytarowski wrote:
>>>>> On 06.06.2017 16:34, Peter Maydell wrote:
>>>>>> On 6 June 2017 at 14:38, Kamil Rytarowski <address@hidden> wrote:
>>>>>>> I've linked qemu with the original patch and:
>>>>>>> ./configure --disable-linux-user --disable-system --static
>>>>>>>
>>>>>>> I got some warnings, I think they are originated from our libc and are
>>>>>>> not related to qemu:
>>>>>>>   LINK    sparc64-bsd-user/qemu-sparc64
>>>>>>> /usr/lib/libc.a(initfini.o): warning: common of `__ps_strings'
>>>>>>> overridden by definition
>>>>>>> /usr/lib/crt0.o: warning: defined here
>>>>>>> /usr/lib/libc.a(_env.o): warning: multiple common of `environ'
>>>>>>> /usr/lib/crt0.o: warning: previous common is here
>>>>>>> /usr/lib/libc.a(getprogname.o): warning: common of `__progname'
>>>>>>> overridden by definition
>>>>>>> /usr/lib/crt0.o: warning: defined here
>>>>>>
>>>>>> Yes, I think I've seen those before on NetBSD -- they look
>>>>>> like a bug in your libc to me, it shouldn't be confusing itself
>>>>>> with itself like that :-)
>>>>>>
>>>>>> thanks
>>>>>> -- PMM
>>>>>>
>>>>>
>>>>> I have filed this bug upstream: http://gnats.netbsd.org/52278
>>>>>
>>>>>
>>>>
>>>>
>>>> What's the status with this patch?
>>>>
>>>> NetBSD build still breaks due to ivshmem-*.
>>>
>>> I guess Michael expects a v4 that doesn't break the static build.
>>>
>>
>> -static works for me, I have restricted options to test build on !NetBSD
>> systems.
>>
>> Was this patch ok?
>>
>> diff --git a/Makefile b/Makefile
>> index c830d7a..2ef5a78 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -469,10 +469,12 @@ ifneq ($(EXESUF),)
>>  qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI)
>>  endif
>>
>> +ifdef CONFIG_IVSHMEM
>>  ivshmem-client$(EXESUF): $(ivshmem-client-obj-y) $(COMMON_LDADDS)
>>      $(call LINK, $^)
>>  ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) $(COMMON_LDADDS)
>>      $(call LINK, $^)
>> +endif
>>
>>
>> So I could amend it.
> 
> Please do.  Additionally consider
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index f42f3df..ab70d01 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -203,7 +203,7 @@ gcov-files-pci-y += hw/display/virtio-gpu-pci.c
>  gcov-files-pci-$(CONFIG_VIRTIO_VGA) += hw/display/virtio-vga.c
>  check-qtest-pci-y += tests/intel-hda-test$(EXESUF)
>  gcov-files-pci-y += hw/audio/intel-hda.c hw/audio/hda-codec.c
> -check-qtest-pci-$(CONFIG_EVENTFD) += tests/ivshmem-test$(EXESUF)
> +check-qtest-pci-$(CONFIG_IVSHMEM) += tests/ivshmem-test$(EXESUF)
>  gcov-files-pci-y += hw/misc/ivshmem.c
>  
>  check-qtest-i386-y = tests/endianness-test$(EXESUF)
> 

Thank you, I will give it a try.

signature.asc
Description: OpenPGP digital signature