Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h

[Greg Kurz]

On Thu, 22 Jun 2017 17:14:08 +0100
Peter Maydell <address@hidden> wrote:

> On 22 June 2017 at 17:06, Greg Kurz <address@hidden> wrote:
> > Function types cannot reside in the same sorted list as opaque types since
> > they may depend on a type which would be defined later.
> >
> > Of course, the same problem could arise if a function type depends on
> > another function type with greater alphabetical order. Hopefully we
> > don't have that at this time.  
> 
> The other approach would be to put function types somewhere
> else and leave typedefs.h for the simple 'opaque types
> for structures' that it was started as.
> 
> For instance we have include/qemu/fprintf-fn.h as a precedent.
> 

Indeed, and I'm not quite sure why Juan decided to put these types into
typedefs.h instead of a dedicated header file in include/migration... is
it only because it was the quickest fix ?

> thanks
> -- PMM

pgpi1cp72nbra.pgp
Description: OpenPGP digital signature