[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] sockets: avoid formatting buffer that may
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [PATCH v2] sockets: avoid formatting buffer that may not be NUL terminated |
|
Date: |
Mon, 26 Jun 2017 11:42:25 +0100 |
On 26 June 2017 at 11:37, Daniel P. Berrange <address@hidden> wrote:
> The 'sun_path' field in the sockaddr_un struct is not required
> to be NUL termianted, so when reporting an error, we must use
"terminated", but hopefully whoever applies the patch can fix the typo?
> the separate 'path' variable which is guaranteed terminated.
>
> Fixes a bug spotted by coverity that was introduced in
>
> commit ad9579aaa16d5b385922d49edac2c96c79bcfb62
> Author: Daniel P. Berrange <address@hidden>
> Date: Thu May 25 16:53:00 2017 +0100
>
> sockets: improve error reporting if UNIX socket path is too long
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM